frontend: visibility of app components is configurable #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilan/dynamic-routes-app-init
branch
2 times, most recently
from
181c3f1
to
204b2d0
Compare
ivakoleva
reviewed
Apr 27, 2023
projects/frontend/data-pipelines/gui/projects/ui/src/app/app.component.spec.ts
Outdated
Show resolved
Hide resolved
ivakoleva
reviewed
Apr 27, 2023
projects/frontend/data-pipelines/gui/projects/ui/src/app/app.component.ts
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilan/dynamic-routes-app-init
branch
4 times, most recently
from
05a29cc
to
22d1dc4
Compare
murphp15
reviewed
Apr 28, 2023
projects/frontend/data-pipelines/gui/e2e/integration/router/router.spec.js
Show resolved
Hide resolved
murphp15
approved these changes
Apr 28, 2023
ivakoleva
approved these changes
Apr 28, 2023
projects/frontend/data-pipelines/gui/e2e/integration/router/router.spec.js
Show resolved
Hide resolved
projects/frontend/data-pipelines/gui/projects/ui/src/app/app-config.service.ts
Outdated
Show resolved
Hide resolved
projects/frontend/data-pipelines/gui/projects/ui/src/app/app.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/frontend/data-pipelines/gui/projects/ui/src/app/app.component.ts
Show resolved
Hide resolved
gorankokin
reviewed
Apr 28, 2023
projects/frontend/data-pipelines/gui/projects/ui/src/app/app-config.service.ts
Outdated
Show resolved
Hide resolved
gorankokin
reviewed
Apr 28, 2023
DeltaMichael
force-pushed
the
person/mdilan/dynamic-routes-app-init
branch
4 times, most recently
from
d5afe9f
to
5ce6cc9
Compare
DeltaMichael
force-pushed
the
person/mdilan/dynamic-routes-app-init
branch
2 times, most recently
from
8b0aa5b
to
3276971
Compare
ivakoleva
reviewed
May 10, 2023
projects/frontend/data-pipelines/gui/projects/ui/src/assets/data/appConfig.json
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilan/dynamic-routes-app-init
branch
from
122068d
to
74b14c4
Compare
gorankokin
approved these changes
May 11, 2023
Why? As part of releasing the UI to the community, we should be able to configure the visibility of certain components that are not intended for external use What? Component visibility for explore page is configurable through AppConfigService Routes are configurable through AppConfigService How was this tested? Locally plus component specs and e2e What type of change is this? Feature, breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilan/dynamic-routes-app-init
branch
from
0e0d05b
to
89715c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
As part of releasing the UI to the community,
we should be able to configure the visibility of
certain components that are not intended for
external use
What?
Component visibility for explore page is configurable through AppConfigService
Routes are configurable through AppConfigService
How was this tested?
Locally plus component specs
What type of change is this?
Feature, breaking