control-service: new python client. #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
dakodakov
approved these changes
Apr 27, 2023
doks5
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The newest python api client is broken and the last working one is very old.
What
In this PR I use the python-nextgen generator instead of the python generator. The behaviour is much more correct and predictable.
There are two bugs in the generated code.
For both these I have created tickets in the openapi generator github project.
I have added string replace workarounds in the gradle step to fix these bugs before we publish the pip package.
next steps(will be tackled in the next few weeks not days): #1982
closes: #1979
How has this been tested?
Locally.
There is actually a draft branch where I import this new version into the cli project and run tests against it to confirm everything is green: #1969
This will always fail in github because 1.0.9 is not released yet till this PR is merged. Then I will open a new PR where I import into cli tool.