control-service: custom app config values can we passed to helm. #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
for more information, see https://pre-commit.ci
duyguHsnHsn
approved these changes
May 2, 2023
…be_passed_to_helm
murphp15
deleted the
person/murphp15/custom_appConfig_values_can_be_passed_to_helm
branch
yonitoo
pushed a commit
that referenced
this pull request
May 3, 2023
# Why We want to be able to change the frontend config depending on the situation it is deployed in. This lets users provide their own appConfig file to the frontend. An example of this is toggling auth on and off. # What Use k8s volumemounts to load in the config file. # How has this been tested? Deployed the helm locally. --------- Signed-off-by: murphp15 <murphp15@tcd.ie> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to be able to change the frontend config depending on the situation it is deployed in.
This lets users provide their own appConfig file to the frontend.
An example of this is toggling auth on and off.
What
Use k8s volumemounts to load in the config file.
How has this been tested?
Deployed the helm locally.