New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control-service: remove unused parameters #2016

Merged

murphp15 merged 21 commits into main from person/murphp15/remove_unused_parameters

May 5, 2023

Collaborator

murphp15 commented May 5, 2023 •

edited

Why

I am trying to improve the stability of the integration tests. I have seen a way of improving them but it requires some code changes.

Before making those code changes I want to push this clean up. as it is very hard to build on the functions that are currently there.

I removed 4 parameters that are never used.
I also removed podLabels which is used but it is always an empty map. So it never did anything.

How was this tested

Unit and integration tests.

murphp15 and others added 6 commits

April 27, 2023 09:56


          control-service: new python client.

2888d2c

Signed-off-by: murphp15 <murphp15@tcd.ie>


          control-service: logs url can contain team name

Signed-off-by: murphp15 <murphp15@tcd.ie>


          Google Java Format

8d213ed


          Merge branch 'main' into person/murphp15/logs_url_can_include_team_name

88d7785


          control-service: logs url can contain team name

450e0ae

Signed-off-by: murphp15 <murphp15@tcd.ie>


          control-service: remove unused parameters

1731cb7

Signed-off-by: murphp15 <murphp15@tcd.ie>

vmwclabot added the cla-not-required label

github-actions and others added 5 commits

May 5, 2023 08:45


          Google Java Format

9d5648a


          build(deps): Bump com.amazonaws:aws-java-sdk-core from 1.12.459 to 1.…

20b93ad

…12.462 in /projects/control-service/projects/pipelines_control_service (#2015)

Bumps
[com.amazonaws:aws-java-sdk-core](https://github.com/aws/aws-sdk-java)
from 1.12.459 to 1.12.462.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md">com.amazonaws:aws-java-sdk-core's
changelog</a>.</em></p>
<blockquote>
<h1><strong>1.12.462</strong> <strong>2023-05-03</strong></h1>
<h2><strong>AWS AppSync</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Private API support for AWS AppSync. With Private APIs, you can now
create GraphQL APIs that can only be accessed from your Amazon Virtual
Private Cloud (&quot;VPC&quot;).</li>
</ul>
</li>
</ul>
<h2><strong>AWS IoT TwinMaker</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This release adds a field for GetScene API to return error code and
message from dependency services.</li>
</ul>
</li>
</ul>
<h2><strong>AWS Network Firewall</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>AWS Network Firewall now supports policy level HOME_NET variable
overrides.</li>
</ul>
</li>
</ul>
<h2><strong>AWS Well-Architected Tool</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This release deepens integration with AWS Service Catalog
AppRegistry to improve workload resource discovery.</li>
</ul>
</li>
</ul>
<h2><strong>Amazon Elastic Compute Cloud</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Adds an SDK paginator for
GetNetworkInsightsAccessScopeAnalysisFindings</li>
</ul>
</li>
</ul>
<h2><strong>Amazon OpenSearch Service</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Amazon OpenSearch Service adds the option to deploy a domain across
multiple Availability Zones, with each AZ containing a complete copy of
data and with nodes in one AZ acting as a standby. This option provides
99.99% availability and consistent performance in the event of
infrastructure failure.</li>
</ul>
</li>
</ul>
<h2><strong>Inspector2</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This feature provides deep inspection for linux based instance</li>
</ul>
</li>
</ul>
<h1><strong>1.12.461</strong> <strong>2023-05-02</strong></h1>
<h2><strong>AWS Resilience Hub</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This release will improve resource level transparency in
applications by discovering previously hidden resources.</li>
</ul>
</li>
</ul>
<h2><strong>AWSKendraFrontendService</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>AWS Kendra now supports configuring document fields/attributes via
the GetQuerySuggestions API. You can now base query suggestions on the
contents of document fields.</li>
</ul>
</li>
</ul>
<h2><strong>Amazon Appflow</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This release adds new API to cancel flow executions.</li>
</ul>
</li>
</ul>
<h2><strong>Amazon Connect Service</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Amazon Connect Service Rules API update: Added
OnContactEvaluationSubmit event source to support user configuring
evaluation form rules.</li>
</ul>
</li>
</ul>
<h2><strong>Amazon EC2 Container Service</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Documentation only update to address Amazon ECS tickets.</li>
</ul>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/aws/aws-sdk-java/commit/978b5ed5c6fdbf5b556fabe461bca2d77075e446"><code>978b5ed</code></a>
AWS SDK for Java 1.12.462</li>
<li><a
href="https://github.com/aws/aws-sdk-java/commit/6312e39cb3a345117a17c8362aa15d2156c4506f"><code>6312e39</code></a>
Update GitHub version number to 1.12.462-SNAPSHOT</li>
<li><a
href="https://github.com/aws/aws-sdk-java/commit/866ca1c85a93f9ffea9d5f3c7bbc816da865fb63"><code>866ca1c</code></a>
AWS SDK for Java 1.12.461</li>
<li><a
href="https://github.com/aws/aws-sdk-java/commit/d5f2307aea67fdcd22eb6eb6eb5a8532d0461be9"><code>d5f2307</code></a>
Update GitHub version number to 1.12.461-SNAPSHOT</li>
<li><a
href="https://github.com/aws/aws-sdk-java/commit/c2c2ba95c0a5c502df78a5ac8dff511a57de1704"><code>c2c2ba9</code></a>
AWS SDK for Java 1.12.460</li>
<li><a
href="https://github.com/aws/aws-sdk-java/commit/d01e3d7fc874d27a71bb0bdbe5007449008fefc8"><code>d01e3d7</code></a>
Update GitHub version number to 1.12.460-SNAPSHOT</li>
<li>See full diff in <a
href="https://github.com/aws/aws-sdk-java/compare/1.12.459...1.12.462">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.amazonaws:aws-java-sdk-core&package-manager=gradle&previous-version=1.12.459&new-version=1.12.462)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          build(deps): Bump com.amazonaws:aws-java-sdk-ecr from 1.12.461 to 1.1…

7c56467

…2.462 in /projects/control-service/projects/pipelines_control_service (#2014)

Bumps
[com.amazonaws:aws-java-sdk-ecr](https://github.com/aws/aws-sdk-java)
from 1.12.461 to 1.12.462.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md">com.amazonaws:aws-java-sdk-ecr's
changelog</a>.</em></p>
<blockquote>
<h1><strong>1.12.462</strong> <strong>2023-05-03</strong></h1>
<h2><strong>AWS AppSync</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Private API support for AWS AppSync. With Private APIs, you can now
create GraphQL APIs that can only be accessed from your Amazon Virtual
Private Cloud (&quot;VPC&quot;).</li>
</ul>
</li>
</ul>
<h2><strong>AWS IoT TwinMaker</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This release adds a field for GetScene API to return error code and
message from dependency services.</li>
</ul>
</li>
</ul>
<h2><strong>AWS Network Firewall</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>AWS Network Firewall now supports policy level HOME_NET variable
overrides.</li>
</ul>
</li>
</ul>
<h2><strong>AWS Well-Architected Tool</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This release deepens integration with AWS Service Catalog
AppRegistry to improve workload resource discovery.</li>
</ul>
</li>
</ul>
<h2><strong>Amazon Elastic Compute Cloud</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Adds an SDK paginator for
GetNetworkInsightsAccessScopeAnalysisFindings</li>
</ul>
</li>
</ul>
<h2><strong>Amazon OpenSearch Service</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Amazon OpenSearch Service adds the option to deploy a domain across
multiple Availability Zones, with each AZ containing a complete copy of
data and with nodes in one AZ acting as a standby. This option provides
99.99% availability and consistent performance in the event of
infrastructure failure.</li>
</ul>
</li>
</ul>
<h2><strong>Inspector2</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This feature provides deep inspection for linux based instance</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/aws/aws-sdk-java/commit/978b5ed5c6fdbf5b556fabe461bca2d77075e446"><code>978b5ed</code></a>
AWS SDK for Java 1.12.462</li>
<li><a
href="https://github.com/aws/aws-sdk-java/commit/6312e39cb3a345117a17c8362aa15d2156c4506f"><code>6312e39</code></a>
Update GitHub version number to 1.12.462-SNAPSHOT</li>
<li>See full diff in <a
href="https://github.com/aws/aws-sdk-java/compare/1.12.461...1.12.462">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.amazonaws:aws-java-sdk-ecr&package-manager=gradle&previous-version=1.12.461&new-version=1.12.462)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Paul Murphy <murphp15@tcd.ie>


          Merge branch 'main' into person/murphp15/remove_unused_parameters

dddb07f


          control-service: remove unused parameters

46073a7

Signed-off-by: murphp15 <murphp15@tcd.ie>

murphp15 changed the title ~~Person/murphp15/remove unused parameters~~ control-service: remove unused parameters

murphp15 and others added 2 commits

May 5, 2023 09:54


          control-service: remove unused parameters

d817c25

Signed-off-by: murphp15 <murphp15@tcd.ie>


          Google Java Format

230da4a

ivakoleva reviewed

View reviewed changes

Contributor

ivakoleva left a comment

May you provide context from GitHub history about why were those added?
Also, you can use stacked PRs to unblock further work

murphp15 and others added 2 commits

May 5, 2023 09:59


          control-service: remove unused parameters

22b799f

Signed-off-by: murphp15 <murphp15@tcd.ie>


          Google Java Format

3fa9314

Collaborator Author

murphp15 commented May 5, 2023

May you provide context from GitHub history about why were those added? Also, you can use stacked PRs to unblock further work

These properties have existed since the inception of the repo. Do you want me to find their history in VMwares internal repos?

murphp15 and others added 2 commits

May 5, 2023 10:04


          control-service: remove unused parameters

8568a55

Signed-off-by: murphp15 <murphp15@tcd.ie>


          Google Java Format

be138c5

DeltaMichael approved these changes

View reviewed changes

Contributor

DeltaMichael left a comment •

edited

This API is horrible. There should be no world in which we have to pass 11 parameters, 3 of which are collections to start a k8s cron job. Can we have a spike ticket to improve it in the future?

Otherwise, I'm happy with the changes.

Collaborator Author

murphp15 commented May 5, 2023

@DeltaMichael
Its known that this class is awful!!! Makes me cry looking at it.
here are two tickets to clean it up #586 #1600

doks5 approved these changes

View reviewed changes

murphp15 enabled auto-merge (squash)

May 5, 2023 09:52

ivakoleva approved these changes

View reviewed changes

github-actions bot and others added 4 commits

May 5, 2023 11:19


          Merge main into person/murphp15/remove_unused_parameters

ec09c64


          control-service: data jobs code lives in data jobs class.

e2b601e

Signed-off-by: murphp15 <murphp15@tcd.ie>


          Google Java Format

6a682ea


          control-service: disable docker build on PRs

7abd56c

Signed-off-by: murphp15 <murphp15@tcd.ie>

murphp15 merged commit d09d2b7 into main

7 checks passed

murphp15 deleted the person/murphp15/remove_unused_parameters branch

May 5, 2023 14:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment