vdk-control-cli: Add support for python_version in config #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
approved these changes
May 10, 2023
projects/vdk-control-cli/tests/resources/test-job-python-version/config.ini
Show resolved
Hide resolved
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/execute.py
Show resolved
Hide resolved
projects/vdk-control-cli/tests/vdk/internal/control/command_groups/job/test_execute.py
Show resolved
Hide resolved
mivanov1988
approved these changes
May 10, 2023
doks5
force-pushed
the
person/andonova/control-cli-python
branch
from
4f700bd
to
79137ac
Compare
As part of the initiative to support multiple python versions for data job deployments, we need to make sure that users can configure their data jobs to use specific python versions, by setting the `python_version` property in the job's **config.ini** file. This change introduces functionality in the vdk-control-cli client to read the python_version configuration set in the job's config.ini file, and deploy the job through `vdk deploy ...` It also adds logic to print the python version of data job deployments as part of the `vdk deploy --show ...` and `vdk execute --show ...` commands. Testing Done: New and existing tests. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/control-cli-python
branch
from
79137ac
to
6cd919a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the initiative to support multiple python versions for data job deployments, we need to make sure that users can configure their data jobs to use specific python versions, by setting the
python_versionproperty in the job's config.ini file.This change introduces functionality in the vdk-control-cli client to read the python_version configuration set in the job's config.ini file, and deploy the job through
vdk deploy ...It also adds logic to print the python version of data job deployments as part of the
vdk deploy --show ...andvdk execute --show ...commands.Additionally, a new test data job is added (alongside a zip archive in projects/vdk-control-cli/tests/resources/job-zip), whose config.ini file contains the python_version property set to 3.8. This job is used in tests.
Testing Done: New and existing tests.