Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: shareable links with query params for Data Jobs grids #2049

Merged
merged 6 commits into from
May 16, 2023
Merged

frontend: shareable links with query params for Data Jobs grids #2049

merged 6 commits into from
May 16, 2023

Conversation

hzhristova
Copy link
Contributor

Save filter changes from Data Jobs Explore and Manage grids as queryParams:

Changes :

  1. Add new GridFilter interface that contains possible filters
  2. Save initial query params if any
  3. Save every filter change as query param and update the link

Testing: local

@hzhristova hzhristova self-assigned this May 11, 2023
ivakoleva
ivakoleva approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gorankokin gorankokin merged commit 4abae68 into main May 16, 2023
12 checks passed
@gorankokin gorankokin deleted the person/hzhristova/Shareble-grids-urls branch May 16, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivakoleva ivakoleva ivakoleva approved these changes

@gorankokin gorankokin gorankokin approved these changes

Assignees

@hzhristova hzhristova

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hzhristova @ivakoleva @gorankokin @vmwclabot