Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: see more details when there is an error #2050

Merged
merged 12 commits into from
May 20, 2023

Conversation

murphp15
Copy link
Collaborator

@murphp15 murphp15 commented May 11, 2023

Why

at the moment when the test fails we don't know what the actual result was.

What

In this PR I print out the actual status and the response body

How was this tested

Locally

murphp15 and others added 2 commits May 11, 2023 15:22
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 changed the title control-service: see error message [draft] control-service: see error message May 11, 2023
@murphp15 murphp15 marked this pull request as draft May 11, 2023 14:23
murphp15 and others added 5 commits May 11, 2023 16:12
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 changed the title [draft] control-service: see error message control-service: see more details when there is an error May 18, 2023
@murphp15 murphp15 marked this pull request as ready for review May 18, 2023 10:18
@murphp15 murphp15 enabled auto-merge (squash) May 18, 2023 10:18
@murphp15 murphp15 merged commit 3864a67 into main May 20, 2023
2 checks passed
@murphp15 murphp15 deleted the person/murphp15/see_error_message branch May 20, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants