quickstart-vdk: ignore explore page and widgets in frontend #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? The explore page and widgets are not relevant to users outside of VMWare This also fixes the bug where the frontend does not load on running quickstart-vdk due to missing configuration What? Ignore the explore page and widgets in the control service helm chart How has this been tested? Configuration tested locally Helm chart tested in CI What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
ivakoleva
approved these changes
May 17, 2023
ivakoleva
reviewed
May 17, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
murphp15
approved these changes
May 17, 2023
yonitoo
pushed a commit
that referenced
this pull request
May 18, 2023
## Why? The explore page and widgets are not relevant to users outside of VMWare This also fixes the bug where the frontend does not load on running quickstart-vdk due to missing configuration ## What? Ignore the explore page and widgets in the control service helm chart ## How has this been tested? Configuration tested locally Helm chart tested in CI ## What type of change are you making? Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The explore page and widgets are not relevant to users outside of VMWare This also fixes the bug where the frontend does not load on running quickstart-vdk due to missing configuration
What?
Ignore the explore page and widgets in the control service helm chart
How has this been tested?
Configuration tested locally
Helm chart tested in CI
What type of change are you making?
Bug fix (non-breaking change which fixes an issue) or a cosmetic change/minor improvement