control-service: Clean up old data job configurations #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
reviewed
May 17, 2023
...pelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/cleanup-old-configs
branch
from
70a3dc2
to
f7c68d0
Compare
ivakoleva
reviewed
May 18, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/templates/_helpers.tpl
Show resolved
Hide resolved
projects/control-service/projects/helm_charts/pipelines-control-service/templates/_helpers.tpl
Show resolved
Hide resolved
murphp15
reviewed
May 18, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
murphp15
approved these changes
May 18, 2023
mivanov1988
approved these changes
May 18, 2023
doks5
force-pushed
the
person/andonova/cleanup-old-configs
branch
from
f7c68d0
to
a3a0675
Compare
doks5
force-pushed
the
person/andonova/cleanup-old-configs
branch
from
a3a0675
to
6ec28eb
Compare
ivakoleva
reviewed
May 22, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/cleanup-old-configs
branch
from
6ec28eb
to
87d26d5
Compare
As part of the initiative to support multiple python versions for data job deployments, we introduced new configurations through the `datajobs.deployment.supportedPythonVersions` and `datajobs.deployment.defaultPythonVersion` properties. This new configuration renders the old configurations through `datajobs.vdk.image` and `datajobs.deployment.dataJobBaseImage` essentially useless, as these are no longer used. This change cleans up the old configurations and related code and tests, so that only the new configurations remain. Testing Done: CI/CD Signed-off-by: Andon Andonov <andonova@vmware.com>
Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/cleanup-old-configs
branch
from
87d26d5
to
7f5e906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the initiative to support multiple python versions for data job deployments, we introduced new configurations through the
datajobs.deployment.supportedPythonVersionsanddatajobs.deployment.defaultPythonVersionproperties. This new configuration renders the old configurations throughdatajobs.vdk.imageanddatajobs.deployment.dataJobBaseImageessentially useless, as these are no longer used.This change cleans up the old configurations and related code and tests, so that only the new configurations remain. A more descriptive list of the changes is as follows:
DOCKER_VDK_BASE_IMAGEandDATAJOBS_DEPLOYMENT_DATAJOBBASEIMAGEenvironment variables are removed, as they are not needed anymore.supportedPythonVersionsfunctionality. Tests associated with the cleaned up logic are also removed.The new configurations were introduced in #2022 and #1935
Testing Done: CI/CD