Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-airflow: fix failing tests #2078

Merged
merged 3 commits into from
May 17, 2023

Conversation

murphp15
Copy link
Collaborator

Why

on the newest python api client we are getting failing test because we check more of the properties in the mock response.

What

Return a dummy response.
The dummy response which has the required properties.

How has this been tested

ran tests locally

Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 merged commit b0fa3c6 into main May 17, 2023
8 checks passed
@murphp15 murphp15 deleted the person/murphp15/fix_airflow_failing_tests branch May 17, 2023 14:48
yonitoo pushed a commit that referenced this pull request May 18, 2023
# Why
on the newest python api client we are getting failing test because we
check more of the properties in the mock response.
# What
Return a dummy response. 
The dummy response which has the required properties. 
# How has this been tested
ran tests locally

---------

Signed-off-by: murphp15 <murphp15@tcd.ie>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants