Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: update ecr credentials integration test #2079

Merged
merged 7 commits into from
May 29, 2023

Conversation

mrMoZ1
Copy link
Contributor

@mrMoZ1 mrMoZ1 commented May 17, 2023

what: added a couple of checks to the integration test to make sure authentication credentials are present.

why: better debugging of the test should it fail.

testing: n/a

Copy link
Contributor

@ivakoleva ivakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of adding the assertions? Was there a misconfig or something?

@mrMoZ1
Copy link
Contributor Author

mrMoZ1 commented May 23, 2023

What is the purpose of adding the assertions? Was there a misconfig or something?

Investigating misconfig issues with the pipeline.

mrMoZ1 and others added 7 commits May 26, 2023 13:57
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
@mrMoZ1 mrMoZ1 merged commit 5b2388d into main May 29, 2023
7 checks passed
@mrMoZ1 mrMoZ1 deleted the person/mzhivkov/ecr-test branch May 29, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants