vdk-jupyter: pin npm packages to previous version #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gageorgiev
approved these changes
May 18, 2023
yonitoo
approved these changes
May 18, 2023
yonitoo
pushed a commit
that referenced
this pull request
May 19, 2023
What: Pinned rendermime-interfaces to 3.6.3. Also removed "@cfaester/enzyme-adapter-react-18": "^0.6.0" which is not used and caused not frequent build errors. Why: Because jupyterlab 4 is released some days ago, and it bumps the latest version of rendermime-interface to 3.8.0, which is not compatible with lumino 1.x This caused Build issues:  Signed-off-by: Duygu Hasan [hduygu@vmware.com](mailto:hduygu@vmware.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Pinned rendermime-interfaces to 3.6.3.
Also removed "@cfaester/enzyme-adapter-react-18": "^0.6.0" which is not used and caused not frequent build errors.
Why:
Because jupyterlab 4 is released some days ago, and it bumps the latest version of rendermime-interface to 3.8.0, which is not compatible with lumino 1.x
This caused Build issues:
Signed-off-by: Duygu Hasan hduygu@vmware.com