control-service: if a test is in a bad state it fails straight away #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
changed the title
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
force-pushed
the
person/murphp15/faster_handling_of_failed_state
branch
from
f1fc952
to
58ae4c1
Compare
Signed-off-by: murphp15 <murphp15@tcd.ie>
murphp15
changed the title
mivanov1988
reviewed
May 29, 2023
...service/src/integration-test/java/com/vmware/taurus/datajobs/it/common/JobExecutionUtil.java
Outdated
Show resolved
Hide resolved
mivanov1988
approved these changes
May 29, 2023
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
DeltaMichael
approved these changes
May 29, 2023
murphp15
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If a test goes into a final state that doesn't match the state we are looking for. we can spend a couple of minutes waiting and checking does it go to the state we want.
examples of this.
We want a job to end with platform error.
The job reports user error.
we will spend 5 minutes checking is it user error.
Total waste of time.
Also if the test fails we will give way more information back in the stacktrace because we are using a callable and an assertion.
so the stacktrace will include the result of the callable. which is very useful.
What
I have added in a fail fast clause that says if the job is not in a running state and not in the final state we want then fail fast.
How was this tested
Locally