Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: print response body on error #2113

Merged
merged 5 commits into from
May 23, 2023

Conversation

murphp15
Copy link
Collaborator

@murphp15 murphp15 commented May 23, 2023

Why

at the moment when the test fails we only know the status code and we have no idea of the details.

What

Now we include the response body in the error message if there is an exception

How was this tested

locally

murphp15 and others added 4 commits May 22, 2023 15:55
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
@murphp15 murphp15 changed the title Person/murphp15/print result body control-service: print response body on error May 23, 2023
@murphp15 murphp15 enabled auto-merge (squash) May 23, 2023 10:24
auto-merge was automatically disabled May 23, 2023 11:16

Base branch requires signed commits

@murphp15 murphp15 merged commit c506c0f into main May 23, 2023
3 checks passed
@murphp15 murphp15 deleted the person/murphp15/print_result_body branch May 23, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants