control-service: allow more time to reach a complete state #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
Signed-off-by: murphp15 <murphp15@tcd.ie>
DeltaMichael
approved these changes
May 29, 2023
doks5
approved these changes
May 29, 2023
murphp15
deleted the
person/murphp15/allow_more_time_to_reach_a_complete_state
branch
|
I feel like we shoud investigate why it needs so much time , How much of a load we are creating just with tests? It's not like real production system with 1000 of jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
when the system is under load jobs often take a little over 5 minutes.
Because we fail fast we won't waste needless time if the job goes into a failed state.
What
Wait longer to get into a successful state
How was this tested
CICD pipeline