vdk-core: Accept string as job_path in JobConfig #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the JobConfig class accepts only pathlib.Path as data_job_path. This, however, causes unnecesary warnings when a string is passed as job path. This change updates the type annotation of the init to support both pathlib.Path and string as data_job_path. Testing Done: CI/CD Signed-off-by: Andon Andonov <andonova@vmware.com>
antoniivanov
approved these changes
Jun 14, 2023
dakodakov
approved these changes
Jun 15, 2023
murphp15
pushed a commit
that referenced
this pull request
Jun 21, 2023
Currently, the JobConfig class accepts only pathlib.Path as data_job_path. This, however, causes unnecesary warnings when a string is passed as job path. This change updates the type annotation of the init to support both pathlib.Path and string as data_job_path. Testing Done: CI/CD Signed-off-by: Andon Andonov <andonova@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the JobConfig class accepts only pathlib.Path as data_job_path. This, however, causes unnecesary warnings when a string is passed as job path.
This change updates the type annotation of the init to support both pathlib.Path and string as data_job_path.
Testing Done: CI/CD