[vdk-plugin] vdk-impala: Make error retries and backoff configurable #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the retries and backoff seconds are hard-coded in the ImpalaErrorHandler, which is not ideal, as there might be users who want to have specific values for these properties. This change adds two new configuration variables, `IMPALA_RETRIES_ON_ERROR` and `IMPALA_ERROR_BACKOFF_SECONDS`, which are to be used for configuring how many times a failed query is to be retried, and how big the backoff should be. Signed-off-by: Andon Andonov <andonova@vmware.com>
antoniivanov
reviewed
Aug 2, 2023
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py
Outdated
Show resolved
Hide resolved
antoniivanov
reviewed
Aug 2, 2023
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Aug 2, 2023
doks5
force-pushed
the
person/andonova/vdk-impala-config
branch
from
ff80171
to
9e92311
Compare
mivanov1988
approved these changes
Aug 2, 2023
antoniivanov
reviewed
Aug 2, 2023
projects/vdk-plugins/vdk-impala/src/vdk/plugin/impala/impala_configuration.py
Outdated
Show resolved
Hide resolved
antoniivanov
approved these changes
Aug 2, 2023
…onfiguration.py Co-authored-by: Antoni Ivanov <aivanov@vmware.com>
doks5
force-pushed
the
person/andonova/vdk-impala-config
branch
from
9e92311
to
34cba0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the retries and backoff seconds are hard-coded in the ImpalaErrorHandler, which is not ideal, as there might be users who want to have specific values for these properties.
This change adds two new configuration variables,
IMPALA_RETRIES_ON_ERRORandIMPALA_ERROR_BACKOFF_SECONDS, which are to be used for configuring how many times a failed query is to be retried, and how big the backoff should be.