vdk-control-cli: add --set-prompt option for secrets #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the --set-prompt option for the secrets command to allow users to set secrets values via a prompt. Signed-off-by: Dako Dakov <ddakov@vmware.com>
murphp15
approved these changes
Aug 3, 2023
Codacy checks. Signed-off-by: Dako Dakov <ddakov@vmware.com>
antoniivanov
reviewed
Aug 3, 2023
There was a problem hiding this comment.
If we have vdk secrets --set-prompt I think we should have vdk properties --set-prompt
Because I think they should be consistent interfaces
But also Properties can be used to save sensitive data (if secrets is disabled or if sensitive information is state (e.g user ids) and need to be updated often or some other case)> So it make sense to have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the --set-prompt option for the secrets command to allow users to set secrets values via a prompt.