control-service: support for pyodbc #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why Currently, the base secure image does not contain required libraries for pyodbc package. What Installed required native dependencies. Testing Done Locally through the following command: ``` docker buildx build -f versatile-data-kit/projects/control-service/projects/job-builder-secure/Dockerfile.python.vdk -t test-image-tag . --build-arg job_githash=localhsh1 --build-arg base_image=registry.hub.docker.com/versatiledatakit/data-job-base-python-3.8-secure:latest --build-arg job_name="data_job_name" --progress=plain ``` Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
dakodakov
approved these changes
Aug 7, 2023
antoniivanov
approved these changes
Aug 7, 2023
I think It does not. |
Then do we need that change there? Also how does it work? In Super Collider if I am not mistake the normal image is still used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, the base secure image does not contain the required libraries for
pyodbcPython package.What
Installed required native dependencies.
Testing Done
Locally through the following command:
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com