Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-jupyter: add testing to CI/CD #2541

Merged
merged 30 commits into from
Aug 28, 2023

Conversation

yonitoo
Copy link
Contributor

@yonitoo yonitoo commented Aug 9, 2023

What:
Add test stage to the .plugin-ci.yml file of the vdk-jupyter plugin.

Why:
Right now, there is a build and release stage but we would want to run the tests every time to ensure code robustness.

Testing Done:
The Gitlab pipeline is green.

Server tests failure Frontend tests failure

Signed-off-by: Yoan Salambashev ysalambashev@vmware.com

@murphp15
Copy link
Collaborator

It is very important to test this with failing cases and make sure the report makes it obvious which tests have failed.

@antoniivanov
Copy link
Collaborator

It is very important to test this with failing cases and make sure the report makes it obvious which tests have failed.

That's a very good point. Let us get into practice for tests to verify the "failing" logs, we should link a fail CI or uploaded failed logs in the Testing Done section so other people can see if they find it easy to understand the problem (since what is easy to see to me often it is not so to someone else).

@yonitoo yonitoo force-pushed the person/ysalambashev/vdk-juoyter-add-test-stage branch from 2872165 to f108311 Compare August 22, 2023 14:01
@antoniivanov
Copy link
Collaborator

It is very important to test this with failing cases and make sure the report makes it obvious which tests have failed.

That's a very good point. Let us get into practice for tests to verify the "failing" logs, we should link a fail CI or uploaded failed logs in the Testing Done section so other people can see if they find it easy to understand the problem (since what is easy to see to me often it is not so to someone else).

Can you please add in testing done links to "failed" (even if faked) runs of gitlab tests so that we can see how easy it is to find the issue. Sort of like testing the error scenario for the CICD.

@antoniivanov
Copy link
Collaborator

antoniivanov commented Aug 25, 2023

I clicked to update your branch becasue there were some unrelated tests getting started. But it did not work properly.
You need to do git pull --rebase --autostash origin main locally and force push

The frontend tests are missing from the test report: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/978573326/test_report

Yoan Salambashev added 16 commits August 28, 2023 10:43
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Yoan Salambashev added 8 commits August 28, 2023 10:55
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
@yonitoo yonitoo force-pushed the person/ysalambashev/vdk-juoyter-add-test-stage branch from 188a2e1 to 42336ab Compare August 28, 2023 07:57
@yonitoo
Copy link
Contributor Author

yonitoo commented Aug 28, 2023

Addressed. The Frontend tests are not showing up in the test report.

Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good . Thanks!

@yonitoo yonitoo merged commit e42de69 into main Aug 28, 2023
8 of 9 checks passed
@yonitoo yonitoo deleted the person/ysalambashev/vdk-juoyter-add-test-stage branch August 28, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants