vdk-jupyter: remove cell outputs before deployment #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…com:vmware/versatile-data-kit into person/hduygu/vdk-jupyter-remove-cell-outputs-before-deployment
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/handlers.py
Outdated
Show resolved
Hide resolved
...dk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/jupyter_notebook.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-jupyter-remove-cell-outputs-before-deployment
branch
from
71df16e
to
4517623
Compare
…s-before-deployment
for more information, see https://pre-commit.ci
...dk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/jupyter_notebook.py
Outdated
Show resolved
Hide resolved
DeltaMichael
approved these changes
Aug 24, 2023
…ployment' of github.com:vmware/versatile-data-kit into person/hduygu/vdk-jupyter-remove-cell-outputs-before-deployment
antoniivanov
requested changes
Aug 24, 2023
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
...-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/tests/test_remove_cell_outputs.py
Outdated
Show resolved
Hide resolved
...-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/tests/test_remove_cell_outputs.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/vdk_jupyterlab_extension/vdk_ui.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
…ployment' of github.com:vmware/versatile-data-kit into person/hduygu/vdk-jupyter-remove-cell-outputs-before-deployment
…s-before-deployment
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
antoniivanov
approved these changes
Aug 24, 2023
duyguHsnHsn
deleted the
person/hduygu/vdk-jupyter-remove-cell-outputs-before-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: added fuctionality to remove cell outputs before deployment
Why: Currently, we do not remove cell outputs when deploying a notebook job which makes it really hard for version control and populates the deployed notebook with unneeded information.
Testing: pytest tests
Signed-off-by: Duygu Hasan hduygu@vmware.com