vdk-kerberos-auth: enable auth to work inside a running asyncio event loop #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
changed the title
…nc event loop
This change adds _run_coroutine function to ensure proper execution of a
get_tgt coroutine, even if called within an already running event loop
in asyncio (which in principal is not allowed)
This is happening when the plugin is invoked within a jupyter notebook
which runs within a async event loop started by tornado server.
And this causes following errors:
```
Traceback (most recent call last):
File
"/opt/conda/lib/python3.7/site-packages/vdk/plugin/kerberos/minikerberos_authenticator.py",
line 90, in _kinit
loop.run_until_complete(get_tgt())
File "/opt/conda/lib/python3.7/asyncio/base_events.py", line 563, in
run_until_complete
self._check_runnung()
File "/opt/conda/lib/python3.7/asyncio/base_events.py", line 526, in
_check_runnung
'Cannot run the event loop while another loop is running')
RuntimeError: Cannot run the event loop while another loop is running
```
The way the fix works is
- If the current event loop is running, the function now starts a new
thread to run the coroutine, ensuring that it runs to completion without
conflict with the existing loop.
- Otherwise it creates a new asyncio event loop in the current thread
and runs the couritine as before.
antoniivanov
force-pushed
the
person/aivanov/vdk-kerberos
branch
from
617d152
to
c966d07
Compare
projects/vdk-plugins/vdk-kerberos-auth/src/vdk/plugin/kerberos/minikerberos_authenticator.py
Show resolved
Hide resolved
DeltaMichael
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds _run_coroutine function to ensure proper execution of a get_tgt coroutine, even if called within an already running event loop in asyncio (which in principal is not allowed)
This is happening when the plugin is invoked within a jupyter notebook which runs within a async event loop started by tornado server. And this causes following errors:
The way the fix works is