-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: add support for multiple jwt issuers #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
...ol-service/projects/base/src/main/java/com/vmware/taurus/security/SecurityConfiguration.java
Outdated
Show resolved
Hide resolved
...ol-service/projects/base/src/main/java/com/vmware/taurus/security/SecurityConfiguration.java
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
antoniivanov
reviewed
Sep 1, 2023
...ol-service/projects/base/src/main/java/com/vmware/taurus/security/SecurityConfiguration.java
Show resolved
Hide resolved
antoniivanov
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will be out most of next week. So I will approve it as it looks good.
Make sure to test all the cases I outlined please. And of course any other you think is needed.
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
doks5
approved these changes
Sep 4, 2023
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
force-pushed
the
person/mzhivkov/csp-tokens
branch
from
September 4, 2023 14:26
d5d7f39
to
e9540b3
Compare
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: added support for multiple jwt issuers. Added an extra env variable to handle the extra issuers since the primary - spring.security.oauth2.resourceserver.jwt.issuer-uri; is a part of spring boot's configuration. Any extra issuers should be listed in datajobs.authorization.oauth2.resourceserver.jwt.extra-issuer.uris;
why: user use case dictates the need for more than a single issuer.
testing:
Tested locally - manually :
A) If authentication is disabled and issue uri is empty , things work API requests can be made.
B) If auth is disabled but uris is not empty, then again you can do some operation without authentication.
C) if auth is ENABLED and URI is not empty - you are required authentication token - tested with tokens from two different issuers, and with non valid token as well as one of the authentication URI variables empty. Authentication works.
D) if auth is ENABLED and URI is empty - some error should show up.