vdk-core: add log stacktrace flag #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/log-stack-trace-flag
branch
from
75d35b0
to
8b0d6b1
Compare
projects/vdk-core/src/vdk/internal/builtin_plugins/config/vdk_config.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/config/vdk_config.py
Outdated
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/log-stack-trace-flag
branch
2 times, most recently
from
3125b82
to
c5c48a2
Compare
antoniivanov
approved these changes
Sep 13, 2023
Why? When we log the stack trace, we're logging exceptions that we've already logged during execution. This increases the logs length by about 30%. What? Add flag that disables/enables logging the stack trace on exit code 1 How has this been tested? Ran vdk locally with a failing data job What type of change are you making? Feature/non-breaking
DeltaMichael
force-pushed
the
person/mdilyan/log-stack-trace-flag
branch
from
c5c48a2
to
3a48035
Compare
gageorgiev
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When we log the stack trace, we're logging exceptions that we've already logged during execution. This increases the logs length by about 30%.
What?
Add flag that disables/enables logging the stack trace on exit code 1
How has this been tested?
Ran vdk locally with a failing data job
What type of change are you making?
Feature/non-breaking