control-service: implement Webhook APIs authentication #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why If a data job authenticates against the Control Service via Kerberos, the Control Service won't be able to forword the access token to webhook APIs, because it does not exist. What Implemented method for obtaining oAuth2 access token via refresh token. Testing Done: Locally against real oAuth Authorization Server. Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mrMoZ1
approved these changes
Sep 12, 2023
dakodakov
approved these changes
Sep 13, 2023
mivanov1988
deleted the
person/miroslavi/implement-webhook-authentication
branch
...ol_service/src/main/java/com/vmware/taurus/authorization/provider/AuthorizationProvider.java
Show resolved
Hide resolved
...ol_service/src/main/java/com/vmware/taurus/authorization/provider/AuthorizationProvider.java
Show resolved
Hide resolved
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Show resolved
Hide resolved
mivanov1988
added a commit
that referenced
this pull request
Sep 14, 2023
Adressing comments from #2655
mivanov1988
added a commit
that referenced
this pull request
Sep 14, 2023
Adressing comments from #2655
mivanov1988
added a commit
that referenced
this pull request
Sep 15, 2023
Adressing comments from #2655
mivanov1988
added a commit
that referenced
this pull request
Sep 15, 2023
Adressing comments from #2655 --------- Co-authored-by: github-actions <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If a data job authenticates against the Control Service via Kerberos, the Control Service won't be able to forward the access token to webhook APIs, because it does not exist.
What
Implemented method for obtaining oAuth2 access token via refresh token.
Testing Done:
Locally against real oAuth2 Authorization Server.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com