vdk-control-api-auth: [bug-fix] authorization header base64 encoding #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
approved these changes
Sep 14, 2023
mivanov1988
approved these changes
Sep 14, 2023
Currently, when using PKCE authorization, the client_secret is set to None when the base64 string is encoded. This leads to some authorization endpoints to not properly decode the `authorization` header and fail the authorization process. This change converts the None object to an empty string, when PKCE is used, in order to make the resulting base64-encoded string compatible with more authorization endpoints. Testing done: Local testing against a production authorization endpoint and a unit test. Signed-off-by: Andon Andonov <andonova@vmware.com>
Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/auth-plugin-fix
branch
from
1752d43
to
b48abd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using PKCE authorization, the client_secret is set to None when the base64 string is encoded. This leads to some authorization endpoints to not properly decode the
authorizationheader and fail the authorization process.This change converts the None object to an empty string, when PKCE is used, in order to make the resulting base64-encoded string compatible with more authorization endpoints.
Testing done: Local testing against a production authorization endpoint and a unit test.