Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: add missing packages to secure job builder #2662

Conversation

mivanov1988
Copy link
Contributor

Why
Data job deployment failed during the matplotlib package installation.

8 60.08       gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DFREETYPE_BUILD_TYPE=system -DPY_ARRAY_UNIQUE_SYMBOL=MPL_matplotlib_ft2font_ARRAY_API -DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -D__STDC_FORMAT_MACROS=1 -Iextern/agg24-svn/include -I/tmp/pip-install-atzjoqx1/matplotlib_1e02350272024504a89afb59eea4cc59/.eggs/numpy-1.25.2-py3.9-linux-x86_64.egg/numpy/core/include -I/usr/local/include/python3.9 -c src/checkdep_freetype2.c -o build/temp.linux-x86_64-cpython-39/src/checkdep_freetype2.o

What
Added missing linux packages freetype2-devel and libpng-devel.

Testing Done:
Locally via the following command:

docker buildx build -f versatile-data-kit/projects/control-service/projects/job-builder-secure/Dockerfile.python.vdk -t test-image-tag . --build-arg job_githash=localhsh1 --build-arg base_image=registry.hub.docker.com/versatiledatakit/data-job-base-python-3.9-secure:latest --build-arg job_name="example8" --progress=plain

Why
Data job deployment failed during the `matplotlib` package installation.

```
8 60.08       gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DFREETYPE_BUILD_TYPE=system -DPY_ARRAY_UNIQUE_SYMBOL=MPL_matplotlib_ft2font_ARRAY_API -DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -D__STDC_FORMAT_MACROS=1 -Iextern/agg24-svn/include -I/tmp/pip-install-atzjoqx1/matplotlib_1e02350272024504a89afb59eea4cc59/.eggs/numpy-1.25.2-py3.9-linux-x86_64.egg/numpy/core/include -I/usr/local/include/python3.9 -c src/checkdep_freetype2.c -o build/temp.linux-x86_64-cpython-39/src/checkdep_freetype2.o
```

What
Added missing linux packages `freetype2-devel` and `libpng-devel`.

Testing Done:
Locally via the following command:

```
docker buildx build -f versatile-data-kit/projects/control-service/projects/job-builder-secure/Dockerfile.python.vdk -t test-image-tag . --build-arg job_githash=localhsh1 --build-arg base_image=registry.hub.docker.com/versatiledatakit/data-job-base-python-3.9-secure:latest --build-arg job_name="example8" --progress=plain
```
@mivanov1988 mivanov1988 merged commit 27ac79e into main Sep 14, 2023
13 checks passed
@mivanov1988 mivanov1988 deleted the person/miroslavi/add-missing-linux-packages-to-secure-job-builder branch September 14, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants