control-service: depoyment controller writes deployment entity #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrMoZ1
changed the title
mrMoZ1
changed the title
mrMoZ1
changed the title
mivanov1988
reviewed
Oct 2, 2023
...rol_service/src/main/java/com/vmware/taurus/datajobs/webhook/DeploymentModelConverterV2.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 2, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Outdated
Show resolved
Hide resolved
mrMoZ1
force-pushed
the
person/mzhivkov/update-job-deployment-controller
branch
2 times, most recently
from
e6e8203
to
daf164c
Compare
mivanov1988
reviewed
Oct 3, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 3, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 3, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Show resolved
Hide resolved
mivanov1988
approved these changes
Oct 3, 2023
mivanov1988
reviewed
Oct 3, 2023
...lines_control_service/src/main/java/com/vmware/taurus/datajobs/DeploymentModelConverter.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 3, 2023
...lines_control_service/src/main/java/com/vmware/taurus/datajobs/DeploymentModelConverter.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 3, 2023
...lines_control_service/src/main/java/com/vmware/taurus/datajobs/DeploymentModelConverter.java
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 3, 2023
...lines_control_service/src/main/java/com/vmware/taurus/datajobs/DeploymentModelConverter.java
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 3, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Outdated
Show resolved
Hide resolved
dakodakov
requested changes
Oct 5, 2023
...s/pipelines_control_service/src/main/java/com/vmware/taurus/service/model/JobDeployment.java
Show resolved
Hide resolved
...lines_control_service/src/main/java/com/vmware/taurus/datajobs/DeploymentModelConverter.java
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 10, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Show resolved
Hide resolved
…nt database Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
force-pushed
the
person/mzhivkov/update-job-deployment-controller
branch
from
8e151b3
to
548f057
Compare
dakodakov
approved these changes
Oct 11, 2023
...lines_control_service/src/main/java/com/vmware/taurus/datajobs/DeploymentModelConverter.java
Show resolved
Hide resolved
...s/pipelines_control_service/src/main/java/com/vmware/taurus/service/model/JobDeployment.java
Show resolved
Hide resolved
antoniivanov
approved these changes
Oct 11, 2023
...s_control_service/src/main/java/com/vmware/taurus/datajobs/DataJobsDeploymentController.java
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 12, 2023
...rojects/pipelines_control_service/src/integration-test/resources/application-test.properties
Outdated
Show resolved
Hide resolved
mivanov1988
deleted the
person/mzhivkov/update-job-deployment-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: The DataJobsDeploymentController class now writes to the new deployment entity database if the write flag is enabled.
why: Part of https://github.com/vmware/versatile-data-kit/tree/main/specs/vep-2272-complete-data-job-configuration-persistence
testing: added unit test.