Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-control-cli: pin werkzeug to version 2.3.8 or less #2743

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

DeltaMichael
Copy link
Contributor

@DeltaMichael DeltaMichael commented Oct 2, 2023

Why?

A test is failing due to changes in the werkzeug API.

https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/5203253935

Traceback (most recent call last):
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/werkzeug/serving.py", line 362, in run_wsgi
    execute(self.server.app)
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/werkzeug/serving.py", line 323, in execute
    application_iter = app(environ, start_response)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/werkzeug/wrappers/request.py", line 189, in application
    resp = f(*args[:-2] + (request,))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/pytest_httpserver/httpserver.py", line 841, in application
    response = self.dispatch(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/pytest_httpserver/httpserver.py", line 1225, in dispatch
    handler = self.handlers.match(request)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/pytest_httpserver/httpserver.py", line 575, in match
    if requesthandler.matcher.match(request):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/pytest_httpserver/httpserver.py", line 458, in match
    difference = self.difference(request)
                 ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/pytest_httpserver/httpserver.py", line 432, in difference
    if not self.query_matcher.match(request.query_string):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/venv/lib/python3.11/site-packages/pytest_httpserver/httpserver.py", line 171, in match
    values = self.get_comparing_values(request_query_string)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mdilyan/Projects/versatile-data-kit/projects/vdk-control-cli/tests/vdk/internal/control/command_groups/job/test_list.py", line 271, in get_comparing_values
    query_string = werkzeug.urls.url_decode(request_query_string)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'werkzeug.urls' has no attribute 'url_decode'

What?

Pin the werkzeug version to 2.3.8 or less, where the API we use in the test is still supported.

How was this tested?

Ran test locally and confirmed that it passes

What kind of change is this

Bugfix

Why?

A test is failing due to changes in the werkzeug API.

https://gitlab.com/vmware-analytics/versatile-data-kit/-/jobs/5203253935

What?

Pin the werkzeug version to 2.3.8 or less, where the
API we use in the test is still supported.

How was this tested?

Ran test locally and confirmed that it passes

What kind of change is this

Bugfix

Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
@DeltaMichael DeltaMichael force-pushed the person/mdilyan/werkzeug-version-control-cli branch from 72a4655 to 2cb93d9 Compare October 2, 2023 16:07
@DeltaMichael DeltaMichael merged commit d063983 into main Oct 3, 2023
10 checks passed
@DeltaMichael DeltaMichael deleted the person/mdilyan/werkzeug-version-control-cli branch October 3, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants