Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-coverity: Adding Coverity Scan #2753

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Conversation

shanmathik
Copy link
Contributor

@shanmathik shanmathik commented Oct 3, 2023

Why?
The coverity scan is a SAST scan which is required for every product or service to conform to Vmware SDL procedures.

What?
This job constitutes of a script which downloads the coverity-analysis. Untars the analysis file and then executes the build for various projects to create intermediate folder within the vdk repo. It then combines the intermediate folder and uploads it to the https://scan.coverity.com/.

How has this been tested?
Coverity Scan Test:
The job was triggered to run from a rule based on commit on a private branch and the link for successful pipeline run is here:https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/1024643834.
Only change was the commit branch has been changed to point to main instead of a specific branch before merging.

What type of change are you making?
The change is in the gitlab-ci.yaml file where a new job has been added as part of the existing pipeline configuration. This will create a new stage/job when it is triggered.

@shanmathik shanmathik force-pushed the person/skailasam/vdk-coverity branch from a0c7278 to 82ec20f Compare October 4, 2023 08:07
@antoniivanov
Copy link
Collaborator

Please add Testing Done secttion (with link to the successful pipeline that ran the coverity job) .

Please also describe better what is coverity scanning providing for the project. Why would it be useful to have it in a bit more details.

And lastly please document the new CICD variables in https://github.com/vmware/versatile-data-kit/wiki/Gitlab-CICD

@shanmathik
Copy link
Contributor Author

shanmathik commented Oct 4, 2023

Why?
The coverity scan is a SAST scan which is required for every product or service to conform to Vmware SDL procedures.

What?
This job constitutes of a script which downloads the coverity-analysis. Untars the analysis file and then executes the build for various projects to create intermediate folder within the vdk repo. It then combines the intermediate folder and uploads it to the https://scan.coverity.com/.

How has this been tested?
Coverity Scan Test:
The job was triggered to run from a rule based on commit on a private branch and the link for successful pipeline run is here:https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/1024643834.
Only change was the commit branch has been changed to point to main instead of a specific branch before merging.

What type of change are you making?
The change is in the gitlab-ci.yaml file where a new job has been added as part of the existing pipeline configuration. This will create a new stage/job when it is triggered.

@antoniivanov
Copy link
Collaborator

That's great description. Please do put it in the PR description. The PR description is used as the commit message when merging

@murphp15
Copy link
Collaborator

How do I actually see the report?
For example I just want to see a list of checks and a green tick beside them?

.gitlab-ci.yml Outdated Show resolved Hide resolved
$COVERITY_SCAN_PROJECT_NAME variable has been replaced with versatile-data-kit.
@antoniivanov antoniivanov changed the title vdk-coverity: Adding Coverity Scan for versatile-data-kit repo as part… vdk-coverity: Adding Coverity Scan Oct 16, 2023
@shanmathik shanmathik merged commit 15c58dd into main Oct 16, 2023
12 of 13 checks passed
@shanmathik shanmathik deleted the person/skailasam/vdk-coverity branch October 16, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants