control-service: user-initiated deployment notifications #2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
reviewed
Oct 4, 2023
...nes_control_service/src/main/java/com/vmware/taurus/service/deploy/DataJobsSynchronizer.java
Show resolved
Hide resolved
antoniivanov
reviewed
Oct 4, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Outdated
Show resolved
Hide resolved
dakodakov
approved these changes
Oct 5, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Outdated
Show resolved
Hide resolved
mivanov1988
force-pushed
the
person/miroslavi/user-Initiated-deployment-notifications
branch
from
1304618
to
48a8283
Compare
Why Currently, the new deployment mechanism sends notifications every time, lacking the ability to send them only when the user initiates the deployment. What We modified the method to send notifications exclusively when deployments are initiated by the User, by incorporating a check for DeploymentStatus.NONE which represents user-initiated deployments. Testing done: Unit tests. Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
person/miroslavi/user-Initiated-deployment-notifications
branch
from
b5db3e5
to
034f209
Compare
mivanov1988
force-pushed
the
person/miroslavi/user-Initiated-deployment-notifications
branch
from
1c3d81b
to
bf10af2
Compare
mivanov1988
deleted the
person/miroslavi/user-Initiated-deployment-notifications
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, the new deployment mechanism sends notifications every time, lacking the ability to send them only when the user initiates the deployment.
What
We modified the method to send notifications exclusively when deployments are initiated by the User, by incorporating a check for DeploymentStatus.NONE which represents user-initiated deployments.
Testing done:
Unit tests.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com