vdk-core: move error classifying logic #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-core-errors-change
branch
from
e411d2b
to
c57a7e0
Compare
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-core-errors-change
branch
from
fc8ed41
to
a9d6d48
Compare
for more information, see https://pre-commit.ci
duyguHsnHsn
changed the title
antoniivanov
approved these changes
Oct 11, 2023
DeltaMichael
approved these changes
Oct 11, 2023
for more information, see https://pre-commit.ci
antoniivanov
approved these changes
Oct 12, 2023
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Relocated the logic for error classification from error.py to a new module, error_classifiers.py.
Why:
Over time, the error.py file has grown significantly, accumulating both deprecated and current code for error handling, reporting, and classification. This accumulation has led to a file that's lengthy and challenging to navigate, hindering both readability and maintainability.