vdk-core: test ingestion with multiple threads #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IIngester methods (send_xxx_for_ingestion) should allow being called from multiple threads. But it's never explicitly tested. This test is far from perfect. Testing something is thread safe is not very easy. But it's good to have it because A) it's indication of a contract for future developers B) it's some verification still.
antoniivanov
force-pushed
the
person/aivanov/vdk-core-ingest
branch
from
4b9da2e
to
71fc552
Compare
gageorgiev
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IIngester methods (send_xxx_for_ingestion) should allow being called from multiple threads. But it's never explicitly tested. This test is far from perfect. Testing something is thread safe is not very easy.
But it's good to have it because
A) it's an indication of this thread-safe contract for future developers
B) If there is some serious regression this should catch it even if it doesn't catch some more subtle regressions.