control-service: deployment controller reads from db #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
mrMoZ1
force-pushed
the
person/mzhivkov/deployment-reads
branch
from
8a99d12
to
9194258
Compare
Let's be more specific. |
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 17, 2023
...s_control_service/src/main/java/com/vmware/taurus/datajobs/DataJobsDeploymentController.java
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 17, 2023
...s_control_service/src/main/java/com/vmware/taurus/datajobs/DataJobsDeploymentController.java
Outdated
Show resolved
Hide resolved
mivanov1988
approved these changes
Oct 17, 2023
dakodakov
approved these changes
Oct 18, 2023
mrMoZ1
pushed a commit
that referenced
this pull request
Oct 19, 2023
what: When calling the deploymentList method of the DataJobsDeploymentController class and a job without deployments exists, the API will now return an empty list instead of 404. why: Recent changes in #2800 refactored the method to return 404 instead of empty list in this situation, however this breaks the post deployment test. testing: added unit test. --------- Signed-off-by: mrMoZ1 <mzhivkov@vmware.com> Co-authored-by: github-actions <> Co-authored-by: Miroslav Ivanov <40535952+mivanov1988@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: DataJobDeploymentController now has the functionality to read from the DB.
why: Part of the persistence VEP which can be found here - https://github.com/vmware/versatile-data-kit/tree/main/specs/vep-2272-complete-data-job-configuration-persistence This PR will reduce the overhead on K8S when making API calls to the control-service.
testing: added unit tests.