vdk-core: test exception propagation to user code #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? As part of our run logs initiative, we stopped wrapping non-vdk errors into vdk errors. This should result in errors coming from libraries, templates, etc. being propagated to user code. Users should then be able to handle those errors. This behaviour has not been tested, however. What? Add a functional test that creates a template and runs it. The templates tries to read an empty csv using pandas, which results in a pandas-specific exception. The exception is then handled in a data job that executes the template. How was this tested? Ran the test locally What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/test-propagating-exceptions
branch
from
ef0e134
to
6733f13
Compare
murphp15
approved these changes
Oct 23, 2023
antoniivanov
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As part of our run logs initiative, we stopped wrapping non-vdk errors in vdk errors. This should result in errors coming from libraries, templates, etc. being propagated to user code. Users should then be able to handle those errors. This behaviour has not been tested, however.
What
Add a functional test that creates a template and runs it. The templates tries to read an empty csv using pandas, which results in a pandas-specific exception. The exception is then handled in a data job that executes the template.
How was this tested
Ran the test locally
What kind of change is this
Feature/non-breaking