vdk-heartbeat: Introduce additional sleep when checking deployments #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/heartbeat-fix
branch
from
a81bf19
to
850dfb9
Compare
mivanov1988
approved these changes
Oct 23, 2023
antoniivanov
approved these changes
Oct 24, 2023
With the introduction of the deployment synchronizer, the behaviour of the Control Service, when a data job is deployed, has changed slightly. Now, there is a slight delay between a job status changing from Enabled to Disabled, and the status being reflected in the output of the `vdk deploy --show` command. This causes the vdk heartbeat to fail, as it expects the changes to be applied immediately. This change adds a new check when the `check_deployments()` method is called, whose purpose is to verify that the job status has changed from enabled to disabled, and sleep for a bit if this is not the case. Testing Done: Executed the heartbeat locally with the command ```bash vdk-heartbeat -f test_basic_config.ini ``` Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/heartbeat-fix
branch
from
a94e186
to
50fd3b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the deployment synchronizer, the behaviour of the Control Service, when a data job is deployed, has changed slightly. Now, there is a slight delay between a job status changing from Enabled to Disabled, and the status being reflected in the output of the
vdk deploy --showcommand. This causes the vdk heartbeat to fail, as it expects the changes to be applied immediately.This change adds a new check when the
check_deployments()method is called, whose purpose is to verify that the job status has changed from enabled to disabled, and sleep for a bit if this is not the case.Testing Done: Executed the heartbeat locally with the command