control-service: fix data job image building #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why Changing Python versions without updating gitCommitSha doesn't trigger the build, causing data job issues due to different VDK images. What We improved the logic to check whether the Python version has changed, and if it has, the image building is triggered. Testing done: Unit tests. Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
antoniivanov
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Changing Python versions without updating gitCommitSha doesn't trigger the build, causing data job issues due to different VDK images.
What
We improved the logic to check whether the Python version has changed, and if it has, the image building is triggered.
Testing done:
Unit tests.
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com