control-service: Add GraphQL read from DB #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/graphql-read-update
branch
from
5b69297
to
366c703
Compare
mivanov1988
reviewed
Oct 26, 2023
...nes_control_service/src/main/java/com/vmware/taurus/service/graphql/GraphQLDataFetchers.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 26, 2023
...nes_control_service/src/main/java/com/vmware/taurus/service/graphql/GraphQLDataFetchers.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 26, 2023
...nes_control_service/src/main/java/com/vmware/taurus/service/graphql/GraphQLDataFetchers.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 26, 2023
...nes_control_service/src/main/java/com/vmware/taurus/service/graphql/GraphQLDataFetchers.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 26, 2023
...nes_control_service/src/main/java/com/vmware/taurus/service/graphql/GraphQLDataFetchers.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Oct 26, 2023
...nes_control_service/src/main/java/com/vmware/taurus/service/graphql/GraphQLDataFetchers.java
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/graphql-read-update
branch
2 times, most recently
from
b00dd5d
to
8897ff2
Compare
TODO Signed-off-by: Andon Andonov <andonova@vmware.com>
Currently, when using the GraphQL API, the data job deployment data is read from the kubernetes cronjobs. This works fine in general, but it also means that the kubernetes resources become the single point of truth, which is not ideal. As part of VEP-2272, the deployment information is moved to the DB, which improves speed and reliability. This means that we need a way to read data from the DB, instead of the kubernetes. This change adds support for reading deployment data from the database when using the GrapgQL API. The option to read from the k8s remains. Testing Done: Added test. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/graphql-read-update
branch
from
cd6bf6c
to
37c4b6a
Compare
mivanov1988
approved these changes
Oct 27, 2023
doks5
force-pushed
the
person/andonova/graphql-read-update
branch
from
37c4b6a
to
2e365d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using the GraphQL API, the data job deployment data is read from the kubernetes
cronjobs. This works fine in general, but it also means that the kubernetes resources become the
single point of truth, which is not ideal.
As part of VEP-2272, the deployment information is moved to the DB, which improves speed and
reliability. This means that we need a way to read data from the DB, instead of the kubernetes.
This change adds support for reading deployment data from the database when using the GrapgQL
API. The option to read from the k8s remains.
Testing Done: Added test.