vdk-core: fix bug in error classification #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/fix-error-classification
branch
from
1abd03e
to
dbb824f
Compare
gageorgiev
approved these changes
Oct 26, 2023
DeltaMichael
force-pushed
the
person/mdilyan/fix-error-classification
branch
2 times, most recently
from
3d1b70b
to
d08e906
Compare
projects/vdk-core/src/vdk/internal/builtin_plugins/run/job_input_error_classifier.py
Outdated
Show resolved
Hide resolved
doks5
approved these changes
Oct 27, 2023
DeltaMichael
force-pushed
the
person/mdilyan/fix-error-classification
branch
4 times, most recently
from
1b7cffc
to
9438c73
Compare
Why Errors coming from libraries imported in user code are getting classified as platform errors in the execution result This is caused by the job_input_error_classifier checking for an incorrect attribute of the error object. What Export the _vdk_resolvable_by and _vdk_resolvable_actual attributes to constants and replace wherever they're used in code How has this been tested Functional test What kind of change is this Bugfix Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/fix-error-classification
branch
from
9438c73
to
5e78612
Compare
DeltaMichael
pushed a commit
that referenced
this pull request
Oct 27, 2023
Uncomment tests after #2840 Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
pushed a commit
that referenced
this pull request
Oct 27, 2023
Uncomment tests after #2840 Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Errors coming from libraries imported in user code are getting classified as platform errors in the execution result This is caused by the job_input_error_classifier checking for an incorrect attribute of the error object.
What
Export the _vdk_resolvable_by and _vdk_resolvable_actual attributes to constants and replace wherever they're used in code
How has this been tested
Functional test
What kind of change is this
Bugfix