Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdk-kerberos-auth: fix unit test failing from bad logging config #2923

Merged
merged 16 commits into from
Nov 24, 2023
Merged

vdk-kerberos-auth: fix unit test failing from bad logging config #2923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2fdc6ba
cicd: use latest docker
Nov 21, 2023
33d0b37
cicd: use latest docker
Nov 21, 2023
1478bb0
cicd: use latest docker
Nov 21, 2023
25e510a
cicd: use latest docker
Nov 22, 2023
18789d9
cicd: use latest docker
Nov 22, 2023
d140a14
cicd: use latest docker
Nov 22, 2023
c5d3200
cicd: use latest docker
Nov 22, 2023
302c09d
cicd: use latest docker
Nov 22, 2023
67da869
cicd: use latest docker
Nov 22, 2023
f5de626
cicd: use latest docker
Nov 22, 2023
2bff7dd
cicd: use latest docker
Nov 22, 2023
5fe1187
cicd: use latest docker
Nov 22, 2023
cd5c5d1
cicd: use latest docker
Nov 22, 2023
6f41bab
cicd: use latest docker
Nov 22, 2023
4bc048a
cicd: use latest docker
Nov 22, 2023
0f3a1eb
cicd: use latest docker
Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/vdk-plugins/.plugin-common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
- "projects/vdk-core/src/**/*"

.build-plugin-dind:
image: docker:23.0.1
image: docker:23.0.6
services:
- docker:23.0.1-dind
- docker:23.0.6-dind
variables:
DOCKER_HOST: tcp://localhost:2375
DOCKER_DRIVER: overlay2
Expand Down
2 changes: 2 additions & 0 deletions projects/vdk-plugins/vdk-kerberos-auth/.plugin-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
- export DEBIAN_FRONTEND=noninteractive
- apt-get update
- apt-get install -y krb5-user
# the line below needs to be removed when cryptolib 1.3.1 or 1.4.0 is released https://community.snowflake.com/s/article/Python-Connector-fails-to-connect-with-LibraryNotFoundError-Error-detecting-the-version-of-libcrypto
- pip install https://github.com/wbond/oscrypto/archive/d5f3437ed24257895ae1edd9e503cfb352e635a8.zip
- !reference [.build-plugin, script]
extends: .build-plugin-dind

Expand Down
7 changes: 6 additions & 1 deletion projects/vdk-plugins/vdk-kerberos-auth/tests/test_kerberos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ def setUp(self) -> None:
def test_no_authentication(self):
with mock.patch.dict(
os.environ,
{"VDK_KRB_AUTH_FAIL_FAST": "true"},
{
"VDK_KRB_AUTH_FAIL_FAST": "true",
"VDK_LOG_EXECUTION_RESULT": "True",
},
):
result: Result = self.__runner.invoke(
["run", jobs_path_from_caller_directory("test-job")]
Expand Down Expand Up @@ -67,6 +70,7 @@ def test_kinit_authentication(self):
"VDK_KRB_AUTH": "kinit",
"VDK_KRB_AUTH_FAIL_FAST": "true",
"VDK_KRB5_CONF_FILENAME": krb5_conf_filename,
"VDK_LOG_EXECUTION_RESULT": "True",
},
):
result: Result = self.__runner.invoke(
Expand Down Expand Up @@ -211,6 +215,7 @@ def test_minikerberos_authentication(self):
"VDK_KEYTAB_REALM": "EXAMPLE.COM",
"VDK_KERBEROS_KDC_HOST": "localhost",
"VDK_KRB5_CONF_FILENAME": krb5_conf_filename,
"VDK_LOG_EXECUTION_RESULT": "True",
},
):
result: Result = self.__runner.invoke(
Expand Down
Loading