vdk-control-cli: Modify how data is written to job config.ini #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
approved these changes
Dec 22, 2023
dakodakov
approved these changes
Dec 22, 2023
Currently, the `_set_value()` logic in **JobConfig** uses `fileinput.input()` to traverse the contents of the job config file, and update the keys passed. This works as expected on python versions up to 3.11. It, however breaks on python3.11 on some platforms. For example, it works fine on Ubuntu, but the config file gets truncated on photonOS (the operating system used for the secure base images), which causes job creation failures. This change modifies the `_set_value()` logic to directly read and write the config file's contents, and drops the use of *fileinput*. Testing Done: Added test, and did some local testing using docker containers with different host OSs. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/control-cli-read-config
branch
from
e3e3cc9
to
ac10a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
_set_value()logic in JobConfig usesfileinput.input()to traverse the contents of the job config file, and update the keys passed. This works as expected on python versions up to 3.11. It, however breaks on python3.11 on some platforms. For example, it works fine on Ubuntu, but the config file gets truncated on photonOS (the operating system used for the secure base images), which causes job creation failures.This change modifies the
_set_value()logic to directly read and write the config file's contents, and drops the use of fileinput.Testing Done: Added test, and did some local testing using docker containers with different host OSs.