Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdk-core: do not count memory properties toward the count #3099

Merged
merged 1 commit into from
Feb 9, 2024
Merged

vdk-core: do not count memory properties toward the count #3099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions projects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/properties_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,14 @@
factory_method = self.__properties_builders[
list(self.__properties_builders.keys())[0]
]
elif (
len(self.__properties_builders) == 2
and "memory" in self.__properties_builders.keys()

Check notice on line 116 in projects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/properties_router.py

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

projects/vdk-core/src/vdk/internal/builtin_plugins/job_properties/properties_router.py#L116 

Consider iterating the dictionary directly instead of calling .keys()
):
properties_type = list(self.__properties_builders.keys())[0]
if properties_type == "memory":
properties_type = list(self.__properties_builders.keys())[1]
factory_method = self.__choose_from_default_type(properties_type)
else:
errors.report_and_throw(
errors.VdkConfigurationError(
Expand Down
Loading