control-service: fix data job deployment cpu conversion #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gageorgiev
approved these changes
Feb 14, 2024
Why Currenlty, we can configure data job cpu only in milicores. What Added an ability to provide cpu resources in either milicores or cores. Also, swithced the database cpu unit to cores as it used to be. Testing done: Unit tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
person/miroslav/fix-deployment-cpu-conversion
branch
from
80f384b
to
d7a4605
Compare
mivanov1988
deleted the
person/miroslav/fix-deployment-cpu-conversion
branch
| @@ -0,0 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
There was a problem hiding this comment.
Why are the gradle jar and properties in source controL? I think those are dynamically downloaded on demand when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, we can configure data job CPU only in milicores.
What
Added an ability to provide cpu resources in either milicores or cores. Also, switched the database CPU unit to cores as it used to be.
Testing done:
Unit tests
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com