control-service: fix lastDeployedDate and lastDeployedBy #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the lastDeployedBy and lastDeployedDate do not return from GraphQL API. Testing Done: unit tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
|
Shouldn't we add some check in integration tests? In other words how we'd catch if we do not get them populated in the future again? |
I will add in a separate PR, since it is a bit urgent. |
antoniivanov
approved these changes
Dec 14, 2021
mivanov1988
deleted the
topic/miroslavi/fix-last-deployed-by-and-last-deployed-date
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the lastDeployedBy and lastDeployedDate do not return from
GraphQL API.
Testing Done: unit tests
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com