Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-impala: template .sql missing from python distro #695

Merged

Conversation

ivakoleva
Copy link
Contributor

When running templates, no data is being handled. The cause is
all template .sql steps are missing when python distribution is
bundled.

Added MANIFEST.in file including *.sql files.

Testing Done: did run python sdist, then verified the .sql files
are bundled-in.

Signed-off-by: ikoleva ikoleva@vmware.com

When running templates, no data is being handled. The cause is
all template .sql steps are missing when python distribution is
bundled.

Added MANIFEST.in file including *.sql files.

Testing Done: did run python sdist, then verified the .sql files
are bundled-in.

Signed-off-by: ikoleva <ikoleva@vmware.com>
Copy link
Contributor

@doks5 doks5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivakoleva ivakoleva merged commit 63c4b4b into main Feb 7, 2022
@ivakoleva ivakoleva deleted the person/ikoleva/vdk-impala-distro-package-resources-fix branch February 7, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants