[plugins][vdk-impala] Improve error handling to handle view errors #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
approved these changes
Feb 18, 2022
doks5
force-pushed
the
person/andonova/impala-bugfix
branch
2 times, most recently
from
73c714b
to
901196e
Compare
…errors Currently, the impala error handling logic fails to properly handle TableAlreadyExist exceptions, in cases where these are caused while processing `CREATE VIEW` sql queries. This change modifies the error handling logic to properly handle exceptions caused while processing `CREATE VIEW` queries. Testing Done: Added unit test. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/impala-bugfix
branch
from
901196e
to
8d75731
Compare
Agree, I'll think about some improvements in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the impala error handling logic fails to properly handle
TableAlreadyExist exceptions, in cases where these are caused while processing
CREATE VIEWsql queries.This change modifies the error handling logic to properly handle exceptions
caused while processing
CREATE VIEWqueries.Testing Done: Added unit test.
Signed-off-by: Andon Andonov andonova@vmware.com