vdk-core: lowercase env variables are inferred as configuration #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdk config-help prints all configs in lower-case so it's easy to copy paste it and set it and it's error prone to allow only upper-cased. Spring does the same thing when inferring applicaiton properties from environment variables. Added also better testing around use-cases with configuration in the functional test suite Testing Done: the functional tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
added a commit
that referenced
this pull request
Mar 16, 2022
vdk config-help prints all configs in lower-case so it's easy to copy paste it and set it and it's error prone to allow only upper-cased. Spring does the same thing when inferring applicaiton properties from environment variables. Added also better testing around use-cases with configuration in the functional test suite Testing Done: the functional tests Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vdk config-help prints all configs in lower-case so it's easy to copy
paste it and set it and it's error prone to allow only upper-cased.
Spring does the same thing when inferring applicaiton properties from
environment variables.
Added also better testing around use-cases with configuration in the
functional test suite
Testing Done: the functional tests
Signed-off-by: Antoni Ivanov aivanov@vmware.com