vdk-trino: fix ingesting value with bool type failing #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanaZhivkova
approved these changes
Mar 8, 2022
projects/vdk-plugins/vdk-trino/src/vdk/plugin/trino/ingest_to_trino.py
Outdated
Show resolved
Hide resolved
vdk-trino ingestion was failing if `send_object_for_ingestion` is passed value with type bool (as it was trying to cast it as if it's stirng. Error was "We could not convert the value to that type. Error is bool cast accept only True/true/False/false values." Testing Done: unit tests covered the new case Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
antoniivanov
force-pushed
the
person/aivanov/vdk-trino-types
branch
from
d796ee0
to
91a14dc
Compare
antoniivanov
added a commit
that referenced
this pull request
Mar 16, 2022
vdk-trino ingestion was failing if `send_object_for_ingestion` is passed value with type bool (as it was trying to cast it as if it's stirng. Error was "We could not convert the value to that type. Error is bool cast accept only True/true/False/false values." Testing Done: unit tests covered the new case Signed-off-by: Antoni Ivanov <aivanov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vdk-trino ingestion was failing if
send_object_for_ingestionis passedvalue with type bool (as it was trying to cast it as if it's stirng.
Error was
"We could not convert the value to that type. Error is bool cast accept
only True/true/False/false values."
Testing Done: unit tests covered the new case
Signed-off-by: Antoni Ivanov aivanov@vmware.com