Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person/zverulacis/vdk documentation #853

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

zverulacis
Copy link
Contributor

@zverulacis zverulacis commented Jun 1, 2022

I tried to put all the info in as short, as specific, and useful as possible taking into consideration existing description, Angelica's blogs, and common sense.

Copy link
Contributor

@gageorgiev gageorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small notes; I haven't approved it since I'd like someone more senior to take a look as well.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merge it after addressing Gabriel's comments.

I think we need a picture with perhaps a marketecture of VDK. What do you think?

@antoniivanov
Copy link
Collaborator

I will merge it on your behalf.

@antoniivanov antoniivanov enabled auto-merge (squash) June 7, 2022 11:34
jagita and others added 6 commits June 7, 2022 14:50
…lifying the existing description, the old description can go to Wiki
Co-authored-by: Gabriel Georgiev <45939426+gageorgiev@users.noreply.github.com>
Co-authored-by: Gabriel Georgiev <45939426+gageorgiev@users.noreply.github.com>
Co-authored-by: Gabriel Georgiev <45939426+gageorgiev@users.noreply.github.com>
Co-authored-by: Gabriel Georgiev <45939426+gageorgiev@users.noreply.github.com>
@antoniivanov antoniivanov force-pushed the person/zverulacis/vdk-documentation branch from 1bafcf0 to 4d8a64e Compare June 7, 2022 11:51
@antoniivanov antoniivanov merged commit ccb9ecc into main Jun 7, 2022
@antoniivanov antoniivanov deleted the person/zverulacis/vdk-documentation branch June 7, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants