vdk-core: Fix destination_table referenced early #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the IngesterBase class, we currently pass `destination_table` to the call to `_queue_payload_for_posting` in cases when the objects queue is empty. However, at this point, the destination_table is not defined, which causes an UnboundLocalError to be raised. This change fixes the issue by replacing `destination_table` with `current_destination_table` (set to None by default) which is defined before the call to `_queue_payload_for_posting`. Testing Done: All existing tests pass Signed-off-by: Andon Andonov <andonova@vmware.com>
gageorgiev
approved these changes
Jun 15, 2022
|
Don't forget tests, please. All bug fixes should generally have a test covering them (e.i. the test fails before the fix and passes afterwards). This way we make sure that the bug is properly fixed, that we won't regress again in the future (as bugs tend to resurface). |
doks5
added a commit
that referenced
this pull request
Jun 15, 2022
As part of #864, a change was made that fixes an issue with destination_table referenced before assignment in case the `_objects_queue` of the `IngesterBase` class is empty. However, the change was merged without any tests. This change introduces a unit test that verifies that there are no regressions. Testing Done: Unit test introduced. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
added a commit
that referenced
this pull request
Jun 15, 2022
As part of #864, a change was made that fixes an issue with destination_table referenced before assignment in case the `_objects_queue` of the `IngesterBase` class is empty. However, the change was merged without any tests. This change introduces a unit test that verifies that there are no regressions. Testing Done: Unit test introduced. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
added a commit
that referenced
this pull request
Jun 15, 2022
As part of #864, a change was made that fixes an issue with destination_table referenced before assignment in case the `_objects_queue` of the `IngesterBase` class is empty. However, the change was merged without any tests. This change introduces a unit test that verifies that there are no regressions. Testing Done: Unit test introduced. Signed-off-by: Andon Andonov <andonova@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the IngesterBase class, we currently pass
destination_tableto thecall to
_queue_payload_for_postingin cases when the objects queue is empty.However, at this point, the destination_table is not defined, which causes an
UnboundLocalError to be raised.
This change fixes the issue by replacing
destination_tablewithcurrent_destination_table(set to None by default) which is defined before the call to
_queue_payload_for_posting.Testing Done: All existing tests pass
Signed-off-by: Andon Andonov andonova@vmware.com